-
Notifications
You must be signed in to change notification settings - Fork 3
Release analysis continuation #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfedy
reviewed
Aug 12, 2025
elfedy
reviewed
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! some overall pending things to discuss:
- rpc_endpoints stuff is still there along with some unsolved merge conflicts (seems there was something weird with the history because it is reintroducing validation logic we removed)
- Imo
prodoc_analysis_promptsshould be part of thepromptsmodule. - Added comments on prdoc tool naming and maybe using a templating engine
src/polkadot_sdk_releases.rs
Outdated
| .unwrap_or_else(|| "default".to_string()) | ||
| } | ||
|
|
||
| pub async fn fetch_release_prdocs(release: &str) -> Result<PrdocsResult> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should call this differently given it also gets the github lablels as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to extend the
prdocanalysis so that an LLM can do deeper analysis on it.Roadmap:
prdocs to disk instead of feeding all of it immediately to LLM