Skip to content

Conversation

@matias-gonz
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings October 23, 2025 08:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused Protocol classes from the adapter base modules, cleaning up unnecessary type definitions. The PriceAdapter and AssetAdapter Protocol classes are removed along with their associated typing.Protocol imports, while the concrete BasePriceAdapter and BaseAssetAdapter abstract base classes remain.

  • Removed PriceAdapter Protocol class from price_adapters/base.py
  • Removed AssetAdapter Protocol class from asset_adapters/base.py
  • Removed unused typing.Protocol imports from both files

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/tq_oracle/adapters/price_adapters/base.py Removes unused PriceAdapter Protocol class and typing.Protocol import
src/tq_oracle/adapters/asset_adapters/base.py Removes unused AssetAdapter Protocol class and typing.Protocol import

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@timbrinded timbrinded merged commit ad88ddf into master Oct 23, 2025
6 checks passed
@timbrinded timbrinded deleted the chore/remove-unused-classes branch October 23, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants