-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add PipelineContext #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the pipeline execution by introducing a PipelineContext class to manage shared state across pipeline stages. Instead of passing individual parameters and return values between functions, the context object carries all necessary data through the pipeline.
Key changes:
- Introduces
PipelineContextdataclass to centralize pipeline state management - Converts pipeline functions from returning values to setting context attributes
- Simplifies function signatures by replacing multiple parameters with a single context object
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tq_oracle/pipeline/context.py | New file defining the PipelineContext dataclass with properties for required values |
| src/tq_oracle/pipeline/run.py | Updated to create and pass context through pipeline stages instead of managing intermediate values |
| src/tq_oracle/pipeline/preflight.py | Modified to accept PipelineContext instead of individual parameters |
| src/tq_oracle/pipeline/assets.py | Changed to set aggregated assets in context rather than returning them |
| src/tq_oracle/pipeline/pricing.py | Updated to store pricing results in context instead of returning tuple |
| src/tq_oracle/pipeline/report.py | Modified to retrieve data from context and publish report via context |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…racle into feat/add-pipeline-ctx
…h_report functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…er clarity on asset requirements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #41