Skip to content

Conversation

@matias-gonz
Copy link
Member

Closes #41

Copilot AI review requested due to automatic review settings October 30, 2025 19:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the pipeline execution by introducing a PipelineContext class to manage shared state across pipeline stages. Instead of passing individual parameters and return values between functions, the context object carries all necessary data through the pipeline.

Key changes:

  • Introduces PipelineContext dataclass to centralize pipeline state management
  • Converts pipeline functions from returning values to setting context attributes
  • Simplifies function signatures by replacing multiple parameters with a single context object

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/tq_oracle/pipeline/context.py New file defining the PipelineContext dataclass with properties for required values
src/tq_oracle/pipeline/run.py Updated to create and pass context through pipeline stages instead of managing intermediate values
src/tq_oracle/pipeline/preflight.py Modified to accept PipelineContext instead of individual parameters
src/tq_oracle/pipeline/assets.py Changed to set aggregated assets in context rather than returning them
src/tq_oracle/pipeline/pricing.py Updated to store pricing results in context instead of returning tuple
src/tq_oracle/pipeline/report.py Modified to retrieve data from context and publish report via context

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 30, 2025 19:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 30, 2025 19:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 31, 2025 14:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@timbrinded timbrinded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timbrinded timbrinded merged commit 0d1440e into master Oct 31, 2025
12 checks passed
@timbrinded timbrinded deleted the feat/add-pipeline-ctx branch October 31, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create pipeline context

3 participants