feat: add encoded calldata to publish_to_stdout #59
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds encoded calldata output to the publish_to_stdout function for dry run mode. The changes enable users to see both the report data and the corresponding encoded calldata that would be sent in a real transaction.
Key Changes:
- Modified
publish_to_stdoutto accept anoracle_addressparameter and output encoded calldata alongside the report - Updated test fixtures to use valid Ethereum addresses instead of placeholder strings
- Updated all test assertions to match the new JSON output structure containing both report and encoded calldata
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tq_oracle/report/publisher.py | Added oracle_address parameter to publish_to_stdout and integrated encode_submit_reports to generate and include encoded calldata in output |
| tests/report/test_publisher.py | Updated test fixtures with valid Ethereum addresses and modified assertions to verify the new output structure containing both report and encoded calldata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
almost there but i think we should be using encodeFunctionCall() instead in a new helper so that we decouple the publisher from the safe component.
Currently in this PR we call encode_submit_reports() which ties the two modules together. If you hoist this this into another helper then we can keep publisher and safe separate
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #46