Skip to content

Conversation

@albertov19
Copy link
Collaborator

Summary of Pull Request

This PR introduces significant improvements and refactorings across multiple scripts to enhance functionality, maintainability, and feature support. Key updates include a new whitelist transaction wrapper, support for XCM V5, and cleanup of extrinsic creation logic.

🚀 New Features & CLI Options

  • Added whitelistWrapper in function-helpers.ts and integrated into generic-call-proposer.ts.
  • Introduced a new --whitelist CLI option for toggling whitelisting behavior.

🔄 XCM Version Support & Refactoring

  • Refactored XCM version handling in hrmp-helper.ts:
    • Added support for XCM V5.
    • Updated fee token structures and message construction.
    • Simplified logic for AsMultiLocation, DepositAsset, and weight handling.

🧹 Codebase Cleanup & Maintenance

  • Removed redundant extrinsic creation logic in:
    • generic-call-proposer.ts
    • hrmp-channel-manipulator.ts
    • xcm-asset-registrator.ts
  • Removed unused CLI options (existential-deposit, sufficient, revert-code) from xcm-asset-registrator.ts.

🐛 Bug Fixes & Precision Improvements

  • Fixed relative price calculation in calculate-relative-price.ts by improving float-to-BigInt conversion.
  • Corrected .toHex() usage in sudoWrapper for proper encoding.

🌐 Network Handling

  • Improved network handling in calculate-external-asset-info.ts:
    • Network argument is now passed directly to WsProvider for better support of unsupported networks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants