-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Update to MorphoCloud/MorphoCloudWorkflow@5f1d3ee
List of MorphoCloudWorkflow changes: ``` $ git shortlog 605af12..5f1d3ee --no-merges Jean-Christophe Fillion-Robin (6): fix: Simplify action log links in informational messages fix(create-instance): Improve readability of control instance success message fix(validate-request): Re-organize validation status to take less vertical space fix: Remove redundant comment posted by triggering workflow feat: Append instance and volume names to issue description feat(validate-request): Simplify status report if all tests pass ``` See MorphoCloud/MorphoCloudWorkflow@605af12...5f1d3ee
- Loading branch information
Showing
9 changed files
with
41 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,26 +38,18 @@ jobs: | |
prefix: ${{ vars.INSTANCE_NAME_PREFIX }} | ||
issue_number: ${{ steps.collect_inputs.outputs.issue_number }} | ||
|
||
- name: Find Instance Name Comment | ||
uses: peter-evans/find-comment@v3 | ||
id: fc_instance_name | ||
- name: description (instance name) | ||
uses: julien-deramond/[email protected] | ||
with: | ||
issue-number: ${{ steps.collect_inputs.outputs.issue_number }} | ||
comment-author: "github-actions[bot]" | ||
body-includes: "### Instance Name" | ||
|
||
- name: comment (instance name) | ||
uses: peter-evans/[email protected] | ||
with: | ||
comment-id: ${{ steps.fc_instance_name.outputs.comment-id }} | ||
issue-number: ${{ steps.collect_inputs.outputs.issue_number }} | ||
body: | | ||
### Instance Name | ||
`${{ steps.define.outputs.instance_name }}` | ||
_The instance name is derived from the GitHub issue number using the template `${{ steps.define.outputs.instance_prefix }}instance-NNN`. The instance may also be located in the exosphere interface using this name._ | ||
edit-mode: replace | ||
edit-mode: append | ||
append-separator: newline | ||
|
||
- name: Define volume name | ||
id: define_volume_name | ||
|
@@ -66,26 +58,18 @@ jobs: | |
issue_number: ${{ steps.collect_inputs.outputs.issue_number }} | ||
suffix: ${{ vars.VOLUME_NAME_SUFFIX }} | ||
|
||
- name: Find Volume Name Comment | ||
uses: peter-evans/find-comment@v3 | ||
id: fc_volume_name | ||
- name: description (volume name) | ||
uses: julien-deramond/[email protected] | ||
with: | ||
issue-number: ${{ steps.collect_inputs.outputs.issue_number }} | ||
comment-author: "github-actions[bot]" | ||
body-includes: "### Volume Name" | ||
|
||
- name: comment (volume name) | ||
uses: peter-evans/[email protected] | ||
with: | ||
comment-id: ${{ steps.fc_volume_name.outputs.comment-id }} | ||
issue-number: ${{ steps.collect_inputs.outputs.issue_number }} | ||
body: | | ||
### Volume Name | ||
`${{ steps.define_volume_name.outputs.volume_name }}` | ||
_The volume name is derived from the GitHub issue number using the template `My-Data-NNN${{ steps.define_volume_name.outputs.volume_suffix }}`. The volume may also be located in the exosphere interface using this name._ | ||
edit-mode: replace | ||
edit-mode: append | ||
append-separator: newline | ||
|
||
- name: Find Issue Commands Comment | ||
uses: peter-evans/find-comment@v3 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -172,10 +172,6 @@ jobs: | |
gh workflow run update-issue-from-workflow.yml \ | ||
-f issue_number=$ISSUE_NUMBER \ | ||
-f command_name=$COMMAND_NAME | ||
gh issue comment $ISSUE_NUMBER \ | ||
-b "Workflow **update-issue-from-workflow.yml** triggered by **validate-request.yml** for command <tt>$COMMAND_NAME</tt><br> \ | ||
<br> \ | ||
For details, see https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}_" | ||
env: | ||
ISSUE_NUMBER: ${{ steps.collect_inputs.outputs.issue_number }} | ||
COMMAND_NAME: encode_email | ||
|
@@ -194,7 +190,29 @@ jobs: | |
See details at https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }} | ||
- name: command results comment (status) | ||
if: ${{ success() }} | ||
if: | ||
${{ success() && (steps.check_orcid_format.outputs.valid == 'true' && | ||
steps.check_email_format.outputs.valid == 'true' && | ||
steps.check_confirm_email_format.outputs.valid == 'true' && | ||
steps.check_emails_match.outputs.valid == 'true') }} | ||
uses: peter-evans/[email protected] | ||
with: | ||
issue-number: ${{ steps.collect_inputs.outputs.issue_number }} | ||
body: | | ||
### Validation Results | ||
The validation checks have completed. Below is the status of each check: | ||
| Check | ORCID iD format | Email format | Confirm Email format | Emails match | | ||
| ----------------------- |:----------------------------------------------:|:----------------------------------------------:|:------------------------------------------------------:|:----------------------------------------------:| | ||
| Status | ${{ steps.check_orcid_format.outputs.emojii }} | ${{ steps.check_email_format.outputs.emojii }} | ${{ steps.check_confirm_email_format.outputs.emojii }} | ${{ steps.check_emails_match.outputs.emojii }} | | ||
- name: command results comment (status) | ||
if: | ||
${{ success() && (steps.check_orcid_format.outputs.valid == 'false' || | ||
steps.check_email_format.outputs.valid == 'false' || | ||
steps.check_confirm_email_format.outputs.valid == 'false' || | ||
steps.check_emails_match.outputs.valid == 'false') }} | ||
uses: peter-evans/[email protected] | ||
with: | ||
issue-number: ${{ steps.collect_inputs.outputs.issue_number }} | ||
|
@@ -203,12 +221,9 @@ jobs: | |
The validation checks have completed. Below is the status of each check: | ||
| Check | Status | | ||
| ----------------------- |:-------:| | ||
| ORCID iD format | ${{ steps.check_orcid_format.outputs.emojii }} | | ||
| Email format | ${{ steps.check_email_format.outputs.emojii }} | | ||
| Confirm Email format | ${{ steps.check_confirm_email_format.outputs.emojii }} | | ||
| Emails match | ${{ steps.check_emails_match.outputs.emojii }} | | | ||
| Check | ORCID iD format | Email format | Confirm Email format | Emails match | | ||
| ----------------------- |:----------------------------------------------:|:----------------------------------------------:|:------------------------------------------------------:|:----------------------------------------------:| | ||
| Status | ${{ steps.check_orcid_format.outputs.emojii }} | ${{ steps.check_email_format.outputs.emojii }} | ${{ steps.check_confirm_email_format.outputs.emojii }} | ${{ steps.check_emails_match.outputs.emojii }} | | ||
> [!IMPORTANT] | ||
> If the ORCID iD format is incorrect, edit the issue description to correct it. | ||
|
@@ -218,4 +233,4 @@ jobs: | |
> [!TIP] | ||
> Once the emails are correctly formatted and match, they will be automatically obfuscated for security. | ||
See details at https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }} | ||
See details [here](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}). |