Refactoring CJK character support #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f25b0ba.
Signed-off-by: 舰队的偶像-岛风酱! <[email protected]>
Signed-off-by: 舰队的偶像-岛风酱! <[email protected]>
|
Hoping this can be merged |
Author
I don't have the energy to refactor it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
I don't have support for .Net Standard 1.3 because I can't reference the source generator I wrote when compiling for the .Net Standard 1.3 target framework.
Caution
I noticed that the latest version of Vsual Studio, which has edited this solution, is 2015, and I'm not sure if it will support the source generator correctly. If it doesn't, you may need to use Vsual Studio 2022, or build directly using the .Net SDK CLI.
Close #107
Close #52