Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Copy plugins to publish directory #30

Merged
merged 3 commits into from
Jan 14, 2024
Merged

feat: Copy plugins to publish directory #30

merged 3 commits into from
Jan 14, 2024

Conversation

MrDave1999
Copy link
Owner

@MrDave1999 MrDave1999 commented Jan 14, 2024

Resolves #29

The package was published here: https://www.nuget.org/packages/CopyPluginsToPublishDirectory

@MrDave1999
Copy link
Owner Author

It has been decided to create a target instead of a .props for one reason:

The target files are imported at the end of the project file, so properties such as Configuration and TargetFramework would already be defined. With a .props file, however, it is different, as they are imported at the beginning of the project file, so the value of TargetFramework would not be available (i.e. it is empty).

See https://learn.microsoft.com/en-us/nuget/concepts/msbuild-props-and-targets#packagesconfig-projects

.props is added at the top of the project file; .targets is added at the bottom.

@MrDave1999 MrDave1999 marked this pull request as ready for review January 14, 2024 19:33
@MrDave1999 MrDave1999 merged commit 5fcfe4c into master Jan 14, 2024
@MrDave1999 MrDave1999 deleted the feat/issue-29 branch January 14, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy plugins to publish directory
1 participant