fix #155 and broadcast BotJoinGroupEvent.Invite by GroupIncreaseNoticeEvent completely #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrXiaoM#155 fix1(由于github网页版似乎没法一次修改多个文件)
|
建议先从 Actions 下载测试 |
原来Actions这里会直接出来jar包啊，那很OK，吃完饭我下载测试一下 |
|
测试OK了，创建3人新群/邀请进入低于50人的群/邀请进入几百人的群/进群退群后重新进群，均正常触发BotJoinGroupEvent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在提出此拉取请求时，我确认了以下几点（请复选框）：
填写PR内容：
fix #155 and broadcast BotJoinGroupEvent by GroupIncreaseNoticeEvent completely
完全基于稳定的GroupIncreaseNoticeEvent来广播BotJoinGroupEvent，抛弃基于不稳定的InviteJoinGroupRequest，同时不用考虑二者会重复的问题，修复了#155
根据#155的分析，这样改我认为逻辑上没问题，根据#155评论里的某些原因，本次小改动并未进行本地打包后实机测试，若检查后感觉没问题并合并了，我再下载最新开发版进行实机验证测试