Skip to content

Conversation

@github-actions
Copy link

Automated changes by create-pull-request GitHub action

chrisbobbe and others added 16 commits October 20, 2025 14:05
The linked discussion is about adding documentation; we can link to
that documentation once it's added.
…age"

The API doc is being updated to distinguish the current "image
preview" content node from a new one, "image element presented in
Markdown syntax", which I think we'll just call "inline image". See
PR in progress: zulip/zulip#36226

Related: zulip#1913
This commit is the result of the following commands:
  flutter pub upgrade --major-versions firebase_messaging firebase_core
  tools/upgrade pod

Changelogs:
  https://pub.dev/packages/firebase_core/changelog#420
  https://pub.dev/packages/firebase_messaging/changelog#1603

Notable changes include bump to Firebase Android BoM (34.1.0 to 34.4.0)
and Firebase iOS SDK (12.2.0 to 12.4.0), changelog for those are at:
  https://firebase.google.com/support/release-notes/android
  https://firebase.google.com/support/release-notes/ios

For Android SDK, no notable changes in the FCM component.

For iOS SDK, no changes in the FCM component.
This commit is the result of the following commands:
  flutter pub upgrade --major-versions pigeon
  tools/check --all-files --fix pigeon

Changelog:
  https://pub.dev/packages/pigeon/changelog#2602

There is one change related `@ProxyApi` which we do not use,
and one about improvements to logging errors.
This commit is the result of the following commands:
  flutter pub upgrade --major-versions drift drift_dev
  tools/check --all-files --fix drift

Changelog:
  https://pub.dev/packages/drift/changelog#2290
  https://pub.dev/packages/drift_dev/changelog#2290
To match our `android/app/build.gradle`, and it is similar to a
change earlier this year for Flutter's first-party plugins:
  flutter/packages@bfad6b976
This is related to zulip#1804, and does the same migration for zulip_plugin.
…review

This kind of URL is already covered in the tests of *clusters* of
image previews, but it seems helpful to isolate it like this with
its own comment.

We're also about to add a third variant, testing that we accept
images generated with an arbitrary CAMO_URI, which actually we don't
currently do, so that'll be a regression test.
…O_URI

See discussion:
  https://chat.zulip.org/#narrow/channel/412-api-documentation/topic/documenting.20inline.20images/near/2279454

We already test the `src == href` case, as
ContentExample.imagePreviewSingleNoThumbnail, but I added a test
case for an arbitrary CAMO_URI that fails before this commit.
@github-actions github-actions bot force-pushed the update-translations/weblate branch from fb20751 to 9ef1382 Compare October 27, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants