forked from zulip/zulip-flutter
    
        
        - 
                Notifications
    You must be signed in to change notification settings 
- Fork 0
Update translations from Weblate #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            github-actions
  wants to merge
  16
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
update-translations/weblate
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    The linked discussion is about adding documentation; we can link to that documentation once it's added.
…age" The API doc is being updated to distinguish the current "image preview" content node from a new one, "image element presented in Markdown syntax", which I think we'll just call "inline image". See PR in progress: zulip/zulip#36226 Related: zulip#1913
This commit is the result of the following commands: flutter pub upgrade --major-versions firebase_messaging firebase_core tools/upgrade pod Changelogs: https://pub.dev/packages/firebase_core/changelog#420 https://pub.dev/packages/firebase_messaging/changelog#1603 Notable changes include bump to Firebase Android BoM (34.1.0 to 34.4.0) and Firebase iOS SDK (12.2.0 to 12.4.0), changelog for those are at: https://firebase.google.com/support/release-notes/android https://firebase.google.com/support/release-notes/ios For Android SDK, no notable changes in the FCM component. For iOS SDK, no changes in the FCM component.
This commit is the result of the following commands: flutter pub upgrade --major-versions pigeon tools/check --all-files --fix pigeon Changelog: https://pub.dev/packages/pigeon/changelog#2602 There is one change related `@ProxyApi` which we do not use, and one about improvements to logging errors.
This commit is the result of the following commands: flutter pub upgrade --major-versions drift drift_dev tools/check --all-files --fix drift Changelog: https://pub.dev/packages/drift/changelog#2290 https://pub.dev/packages/drift_dev/changelog#2290
To match our `android/app/build.gradle`, and it is similar to a change earlier this year for Flutter's first-party plugins: flutter/packages@bfad6b976
This is related to zulip#1804, and does the same migration for zulip_plugin.
…review This kind of URL is already covered in the tests of *clusters* of image previews, but it seems helpful to isolate it like this with its own comment. We're also about to add a third variant, testing that we accept images generated with an arbitrary CAMO_URI, which actually we don't currently do, so that'll be a regression test.
…O_URI See discussion: https://chat.zulip.org/#narrow/channel/412-api-documentation/topic/documenting.20inline.20images/near/2279454 We already test the `src == href` case, as ContentExample.imagePreviewSingleNoThumbnail, but I added a test case for an arbitrary CAMO_URI that fails before this commit.
fb20751    to
    9ef1382      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Automated changes by create-pull-request GitHub action