MCR-3458 improve Google Sitemap Handling #2562
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toKrause
requested changes
Jul 30, 2025
| @@ -91,7 +96,8 @@ public final class MCRGoogleSitemapCommon { | |||
| "http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd"; | |||
|
|
|||
| /** The directory path to store sitemaps relative to MCR.WebApplication.basedir */ | |||
| private static final String CDIR = MCRConfiguration2.getString("MCR.GoogleSitemap.Directory").orElse(""); | |||
| private static final Path CDIR = | |||
| Paths.get(MCRConfiguration2.getString("MCR.GoogleSitemap.Directory").orElseThrow()); | |||
There was a problem hiding this comment.
Currently, using this in a fresh MIR, an exception is thrown, when loading the sitemap. Please provide a sensible default value in the mycore.properties of this module, i.e.
MCR.GoogleSitemap.Directory=%MCR.datadir%/sitemap
| @@ -91,7 +96,8 @@ public final class MCRGoogleSitemapCommon { | |||
| "http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd"; | |||
|
|
|||
| /** The directory path to store sitemaps relative to MCR.WebApplication.basedir */ | |||
There was a problem hiding this comment.
Please remove misleading info relative to MCR.WebApplication.basedir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.