Skip to content

MCR-3445 (2) make MCRSolrFileIndexHandler configurable #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

MCR-3445 (2) make MCRSolrFileIndexHandler configurable #2582

wants to merge 4 commits into from

Conversation

rsteph-de
Copy link
Member

@rsteph-de rsteph-de requested a review from Mewel July 17, 2025 13:08
@rsteph-de
Copy link
Member Author

rsteph-de commented Jul 17, 2025 •
edited
Loading

  • code from MCRSolrFileIndexHandler was moved to MCRSolrDefaultFileIndexHandler
  • MCRSolrFileIndexHandler was changed to an interface

Mewel
Mewel previously approved these changes Jul 17, 2025
View reviewed changes
sebhofmann
sebhofmann requested changes Jul 22, 2025
View reviewed changes
Copy link
Member

@sebhofmann sebhofmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we merge this this should go to 2025.12(main). The better Way would be to overwrite the factory and then set IndexHandler.Factory

@rsteph-de
Copy link
Member Author

rsteph-de commented Jul 23, 2025 •
edited
Loading

If we merge this this should go to 2025.12(main). The better Way would be to overwrite the factory and then set IndexHandler.Factory

Thanks for the suggestion, that allows me to use the new behaviour in my 2025.06 LTS application without changes to the MyCoRe LTS branch. But in the future there should be ONE factory which creates configurable instances (as implemented here).

@rsteph-de rsteph-de changed the base branch from 2025.06.x to main July 23, 2025 18:39
@rsteph-de rsteph-de dismissed Mewel’s stale review July 23, 2025 18:39

The base branch was changed.

@rsteph-de rsteph-de force-pushed the issues/MCR-3445-make_MCRSolrFileIndexHandler_configurable branch from 6969028 to 7f3e9db Compare July 23, 2025 18:39
@yagee-de yagee-de marked this pull request as draft July 29, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebhofmann sebhofmann sebhofmann requested changes

@Mewel Mewel Mewel left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsteph-de @Mewel @sebhofmann