MCR-3479 Harmonize and modernize MCRClassificationMappingEventHandler implementations #2596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toKrause
force-pushed
the
issues/MCR-3479_Harmonize-and-modernize-MCRClassificationMappingEventHandler-implementations
branch
3 times, most recently
from
555c0b9 to
84b4e63
Compare
toKrause
force-pushed
the
issues/MCR-3479_Harmonize-and-modernize-MCRClassificationMappingEventHandler-implementations
branch
from
84b4e63 to
5e0b111
Compare
|
#2467 already handles this |
|
In #2467 there is still copious amounts of code duplication and some behavioral inconsistencies in |
|
Yes, but classification mapping is not done in EventHandlers anymore, since the Information/Metadata they create, can always be derived from existing metadata. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.