-
Notifications
You must be signed in to change notification settings - Fork 1
Prep for 24.1 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Prep for 24.1 #28
Conversation
@jmarrec I re-ran EPTravisTester on my last E+ release where I just sorta reverted everything back to Python 3.8 and no ARM build from GHA. As you might see in the commit list, 8c7853e failed, and I was surprised. It wouldn't run the PythonPlugin file from an outside API call. I realized I had bumped TravisTester up to Python 3.12 to run these things, so I did a quick test. I pulled back down to 3.10 -- still failed. So for this niche application of Python API + Python Plugin File Inside EPlus, Pythons definitely MUST match. I'm going to run one more test where I don't run the Plugin file, but use a different Python on GHA. I expect it to pass fine, but I"ll revert it back because I definitely want the API+Plugin test (for now). |
Yep, it's all good. The only issue arises when a user wants to execute a Python Plugin enabled file through an API call into I'm expecting this to be quite an uncommon application, so I think it's time to move on. I'm putting 3.8 back on GHA here and will move on. |
Main change - assuming a more modern Python -- 3.12. For almost all users everywhere, this will not be a problem. For those people who want to use Python API to run EnergyPlus files which may also include Python Plugin files inside ---- they may want to change.