[graphql-alt] Add checks and coin selection argument to simulateTransaction #24679
Conversation
tpham-mysten
requested review from
amnn,
emmazzz,
evan-wall-mysten,
henryachen,
nickvikeras and
wlmyng
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
tpham-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
left a comment
amnn
left a comment
There was a problem hiding this comment.
I think we'll need to approach the test differently to avoid it needing to be changed by folks making unrelated changes, but the core implementation is looking good, thanks @tpham-mysten !
There was a problem hiding this comment.
Is this stale? It looks like you're using an inline snapshot now.
| "status": "SUCCESS", | ||
| "transaction": { | ||
| "gasInput": { | ||
| "gasBudget": "156976000" |
There was a problem hiding this comment.
Even the gas budget may change because of unrelated protocol config or gas model changes. I think it will be best to write a more "E2E" test where we take the output from GraphQL, sign it, execute it, and confirm that this succeeds and the transfer actually happens.
| &self, | ||
| ctx: &Context<'_>, | ||
| transaction: Json, | ||
| checks_enabled: Option<bool>, |
There was a problem hiding this comment.
nit: thoughts on aligning this with gRPC by calling it checks? I know that in gRPC there is a special enum for this which is perhaps where the Enabled comes from, though. (I don't feel particularly strongly either way, but just noted the difference).
Description
Support the same flags that gRPC's simulate transaction supports:
checks: enables transaction validation checks during simulationdo_gas_selection: enables automatic gas coin selection and budget estimationTest plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
checksanddo_gas_selectionargument forquery.simulateTransaction