[graphql-alt] Update IAddressable return types for partial error support [2/n] #24681
+242
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpham-mysten
requested review from
amnn,
emmazzz,
evan-wall-mysten,
henryachen,
nickvikeras and
wlmyng
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
tpham-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
approved these changes
Dec 18, 2025
| before: Option<balance::Cursor>, | ||
| ) -> Result<Option<Connection<String, Balance>>, RpcError<balance::Error>> { | ||
| let pagination: &PaginationConfig = ctx.data()?; | ||
| ) -> Option<Result<Connection<String, Balance>, RpcError<balance::Error>>> { |
Contributor
There was a problem hiding this comment.
This makes me wonder if it might be better to pull these functions out into a separate impl block that returns Result<Option<...>, ...> and then here we call that function and transpose the result.
Contributor
There was a problem hiding this comment.
Or I wonder if you could use your async { ... } trick here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return Type Pattern Change:
but sibling fields still return data
Test plan
How did you test the new or updated feature?
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.