[move-ide] Better on-hover value display for string constants #24704
+36
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
awelc
commented
Dec 19, 2025
| pub edition: Option<Edition>, | ||
| /// Compiler analysis info | ||
| pub compiler_analysis_info: Option<CompilerAnalysisInfo>, | ||
| pub compiler_analysis_info: CompilerAnalysisInfo, |
Contributor
Author
There was a problem hiding this comment.
Changed this while implementing the core of this PR as it irked me that we had an unwrap for this so far away from where it is clear that the unwrap is OK
awelc
commented
Dec 19, 2025
| CompiledProgram, | ||
| ) { | ||
| // run typing analysis for the main user program | ||
| let compiler_analysis_info = compiled_pkg_info.compiler_analysis_info.as_ref().unwrap(); |
Contributor
Author
There was a problem hiding this comment.
This is the old unwrap that I mentioned in https://github.com/MystenLabs/sui/pull/24704/files#r2635378417 that I decided to remove in this PR outside of the PR's core logic as in this position it's tough to argue that it is safe without looking at a completely different part of the code baase
awelc
force-pushed
the
aw/move-ide-const-strings
branch
from
5b36ddc to
eef8e32
Compare
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What the subject says. Before, for byte vectors that are defined in source code using strings we were displaying byte values due to loss of some information during compilation:
When the compiler was modified to preserve the necessary data (#24645), we could fix this in
move-analyzeras well:Test plan
Test output has been updated to reflect new display format. All tests must pass