-
Notifications
You must be signed in to change notification settings - Fork 57
feat: blob sliver data existence check #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning: This PR modifies one of the example config files. Please consider the
|
4557d80
to
0f2ccfa
Compare
2bb613f
to
e2cb416
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me, i hope @liquid-helium can also once take a look and ensure his comments are fully addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I left some comments but we don't need to resolve them in this PR.
Description
This PR implements the basic sliver data existence check conducted along with blob info consistency check
at beginning of every epoch. It exposes a metric which represents the percentage of fully synced blobs that
are actually fully stored. Note that here it has already taken blobs that are being synced into consideration.
Contribute to WAL-701
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)