fix(dbtool): fix drop column family command #2265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liquid-helium Please disregard for now, this doesn't actually fix the problem. |
liquid-helium
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Thanks @mlegner for the changes, looks good to me, only one comment.
mlegner
force-pushed
the
mlegner/fix-db-tool-drop-column-family
branch
from
7206183 to
7af5465
Compare
mlegner
force-pushed
the
mlegner/fix-db-tool-drop-column-family
branch
from
7af5465 to
e886667
Compare
halfprice
pushed a commit
that referenced
this pull request
Jul 12, 2025
halfprice
added a commit
that referenced
this pull request
Jul 12, 2025
* fix(dbtool): fix drop column family command (#2265) * bump to 1.28.4 --------- Co-authored-by: Markus Legner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the
walrus-node db-tool drop-column-familycommand failed with the following error:Apparently it is necessary to open all column families (rust-rocksdb/rust-rocksdb#608). With this PR, we make sure to open all column families. Also, it allows passing multiple CF names to the command.
Test plan