feat(client): add permanent
flag to CLI and publisher
#2281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, blobs are "permanent" as default and can be stored as "deletable" through the
--deletable
CLI option and adeletable
query parameter on the publisher. We want to change this default behavior in the future, at which point we need a way to specify a blob as "permanent". Adding the--permanent
flag in the same release where the default is changed is a bit dangerous as all users would have to change their invocations at exactly that point.Adding the
--permanent
flag now allows users to already start callingwalrus store --permanent [...]
to make sure the behavior is unaffected by the later default change. Additionally, we log a warning about the upcoming default change from permanent to deletable if neither flag is specified.The plan would then be to keep the
--deletable
around for some time longer and log a different warning about the default change if neither flag is specified.Contributes to WAL-911.
Test plan
Manual checks.
Release notes
permanent
query parameter. Warning: In the future, blobs will be stored as deletable by default; to keep the current behavior, you need to add thepermanent=true
query parameter.--permanent
option to thestore
andstore-quilt
commands. Warning: In the future, blobs will be stored as deletable by default; to keep the current behavior, you need to add the--permanent
option when storing blobs.