Default parameters for procedural constraints/scheduling goals #1744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienmaillard
added
feature
adrienmaillard
had a problem deploying
to
e2e-test
GitHub Actions
Failure
adrienmaillard
force-pushed
the
feature/default-scheduling-goal-parameters
branch
from
baa01d8 to
6947330
Compare
adrienmaillard
had a problem deploying
to
e2e-test
GitHub Actions
Failure
adrienmaillard
had a problem deploying
to
e2e-test
GitHub Actions
Failure
adrienmaillard
force-pushed
the
feature/default-scheduling-goal-parameters
branch
from
6947330 to
3196c6c
Compare
adrienmaillard
had a problem deploying
to
e2e-test
GitHub Actions
Failure
adrienmaillard
requested review from
JoelCourtney,
dandelany,
joshhaug and
mattdailis
and removed request for
dandelany and
joshhaug
adrienmaillard
had a problem deploying
to
e2e-test
GitHub Actions
Failure
adrienmaillard
force-pushed
the
feature/default-scheduling-goal-parameters
branch
from
3196c6c to
9ca0ea8
Compare
adrienmaillard
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copy/paste what has been done for the mission model annotations. There's one less type of default parameters as we allow only records when writing procedural goals/constraints.
Same for the endpoints for getting effective arguments. Very similar.
Verification
New tests. I noticed that procedural constraints did not have tests.
Documentation
Documentation about the new annotations and endpoints need to be added
Future work
UI work to use the effective arguments endpoints