[do not merge] preview to validate fix #867
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for visex ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hanbyul-here
added a commit
to NASA-IMPACT/veda-ui
that referenced
this pull request
Jun 10, 2025
…1708) **Related Ticket:** NASA-IMPACT/veda-config#865 ### Description of Changes How we shim the default value for timeDensity, doesn't work when the returned value for timeDensity is incorrect. (In this case, timeDensity value was returned as `daily`, not `day`). This PR handles it. ### Notes & Questions About Changes The dataset still depends on the default fallback, while it has to use the correct value returned from the backend. The data needs to be ingested with the correct value for `dashboard:time_density` (day, instead of daily) ### Validation / Testing PR to generate a preview: NASA-IMPACT/veda-config#867 Preview link: https://deploy-preview-867--visex.netlify.app/data-catalog/GPM_3IMERGDF.v07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.