Adding styles & Configurations for R3 #1104
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
purgecss configuration : FullHuman/purgecss#86 (comment) |
hanbyul-here
force-pushed
the
purge-config
branch
from
cfdafd3 to
c0ff395
Compare
hanbyul-here
force-pushed
the
purge-config
branch
from
932bef3 to
9ac27ea
Compare
There was a problem hiding this comment.
Thank you @hanbyul-here! Looking forward to any future feedback on USWDS usage from @slesaad as well as we continue to transition towards USWDS.
In addition to the docs mentioned in the description, we also have on our disposal the <Grid /> React component from the react implementation of the USWDS library for layout purposes (depends on preference of the developer). Link to the relevant docs: https://trussworks.github.io/react-uswds/?path=/docs/components-grid--docs.
|
Oh!! Thanks a lot for pointing the grid component from react-uswds @dzole0311 ! I didn't even think about it 😓 We probably need to list grid-related classes as a whitelist to use it, though, I guess?
|
## 🎉 Features - 🦗 ## 🚀 Improvements - Adding styles & Configurations for R3 #1104 - Create new raster paint layer module and factor out BaseTimeseriesProps #1105 - Remove PurgeCSS, configure USWDS to use only tablet breakpoints #1112 - Open an external link in a new tab #1116 - Expose USWDS card style #1119 ## 🐛 Fixes - Do not render exploration component unless urlAtom is on the right page #1106
Related Ticket: #1098
Description of Changes
instance/overridesfolder as contentNotes & Questions About Changes
I almost gave up getting purgecss to work, but @dzole0311 helped me figure out what was wrong. (The default extractor doesn't allow special characters like
:, which we need to target specific screen size liketablet:ex. https://designsystem.digital.gov/utilities/layout-grid/ Thank you so much 🙇 @dzole0311 !@slesaad , you don't need to review this PR, but I think it would be beneficial to check how we are importing the styles and purging the styles through
postcss.config.Validation / Testing
This PR doesn't bring any visual change to UI, but this GHG pr uses this branch: US-GHG-Center/veda-config-ghg#482