Fix the label formatting for annual datasets #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
approved these changes
Aug 20, 2024
dzole0311
added a commit
that referenced
this pull request
Aug 20, 2024
**Related Ticket:** #1113 ### Description of Changes The change fixes the label formatting of the timeline view and the datepicker labels when selecting annual datasets. The labels should show only in `yyyy` instead of `MM yyyy` format when annual datasets are the lowest common denominator selected. ### Notes & Questions About Changes _{Add additonal notes and outstanding questions here related to changes in this pull request}_ ### Validation / Testing - Add a dataset with annual time density and verify that the timeline view labels and the datepicker labels show only the year - Add datasets with month time density, and verify that now the labels show the month and the year - The rest should work as before (date picker shows the appropriate calendar view)
dzole0311
added a commit
that referenced
this pull request
Aug 20, 2024
**Related Ticket:** #1113 ### Description of Changes The change fixes the label formatting of the timeline view and the datepicker labels when selecting annual datasets. The labels should show only in `yyyy` instead of `MM yyyy` format when annual datasets are the lowest common denominator selected. ### Notes & Questions About Changes _{Add additonal notes and outstanding questions here related to changes in this pull request}_ ### Validation / Testing - Add a dataset with annual time density and verify that the timeline view labels and the datepicker labels show only the year - Add datasets with month time density, and verify that now the labels show the month and the year - The rest should work as before (date picker shows the appropriate calendar view)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1113
Description of Changes
The change fixes the label formatting of the timeline view and the datepicker labels when selecting annual datasets. The labels should show only in
yyyyinstead ofMM yyyyformat when annual datasets are the lowest common denominator selected.Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing