-
Notifications
You must be signed in to change notification settings - Fork 11
fix: Legend populated after enountering a datset without it #1550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
can you add an example in the mock dataset, so we can validate it in the deploy preview? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. But would be nice to also be reviewed by @hanbyul-here or someone from the ui team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vidhi04bhatia - Thank you for improving the legend! I agree with you that it makes sense to keep the legend to display a title for those satellite layers. It surely does look better than having the transparent rgba(0, 0, 0, 0)
bar in those cases.
I tried the new category with a couple of stories in veda-config and it all looks good to me!
Related Ticket: #1484
Description of Changes
The current .mdx file contains a temporary fix where the legend properties are set to a transparent color to avoid issues with scrollytelling. We will update this to set legends that do not need a color swatch (e.g., categorical or graphical types) to type: text and remove unnecessary properties like stops, color, and label.
Before (Temporary Fix):
After (Updated Configuration):
Notes & Questions About Changes
Would it be better if we could just remove the swatch and keep the legend title instead of removing the legend all together. This would help users who are accessing the story to know what imagery they are look at on the map. Removing the legends entirely could create a sense of unknowingness with what is shown on the map. (implemented in this pull request)
Validation / Testing
Note
The use case for this legend type is for satellite imagery, where we'd still want the information of what is being shown, but don't need to show colors