fix: gas-tags-not-showing #1604
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dzole0311
requested changes
Apr 14, 2025
There was a problem hiding this comment.
Thanks for fixing @BhattaraiSijan! Adding a few nit comments, the rest seems to work as expected.
| @@ -153,6 +153,7 @@ export default function HubContent(props: HubContentProps) { | |||
| {displayStories.map((d) => { | |||
| const pubDate = new Date(d.pubDate); | |||
| const topics = getTaxonomy(d, TAXONOMY_TOPICS)?.values; | |||
| const gases = getTaxonomy(d, 'Gas')?.values; // Retrieve the Gas taxonomy | |||
There was a problem hiding this comment.
@BhattaraiSijan Can we please add a new taxonomy type TAXONOMY_GASES here:
const gases = getTaxonomy(d, TAXONOMY_GASES)?.values
| @@ -225,6 +226,37 @@ export default function HubContent(props: HubContentProps) { | |||
| ))} | |||
| </CardTopicsList> | |||
| ) : null} | |||
| {gases?.length ? ( // Render Gas pills | |||
There was a problem hiding this comment.
Can we please remove obsolete comments like this?
| @@ -153,6 +153,7 @@ export default function HubContent(props: HubContentProps) { | |||
| {displayStories.map((d) => { | |||
| const pubDate = new Date(d.pubDate); | |||
| const topics = getTaxonomy(d, TAXONOMY_TOPICS)?.values; | |||
| const gases = getTaxonomy(d, 'Gas')?.values; // Retrieve the Gas taxonomy | |||
There was a problem hiding this comment.
Also, can we also please make sure to clean up obsolete comments like // Retrieve the Gas taxonomy?
|
Closed PR because it turns out it was the intended behavior that only TOPICS be shown as those pills. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: NASA-IMPACT/veda-ui#1597
Description of Changes
This pull request resolves the issue where the "Gas" taxonomy pills (e.g.,
CH₄,CO₂) were not being rendered in the footer of story cards. The following changes were made:HubContentcomponent to retrieve the "Gas" taxonomy using thegetTaxonomyfunction.Notes & Questions About Changes
getTaxonomyfunction was already available and used to retrieve taxonomy data for "Topics." It was reused to fetch the "Gas" taxonomy.CardTopicsListandPillcomponents were sufficient for rendering the pills.Validation / Testing [Link : deploy preview]
CH₄,CO₂) are displayed in the footer of story cards when the "Gas" taxonomy is present in the story metadata.