fix: Consolidate RasterPaintLayer #1607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
force-pushed
the
1545-move-to-raster-paint-layer
branch
from
8794713 to
3f4912c
Compare
hanbyul-here
changed the title
hanbyul-here
changed the title
hanbyul-here
changed the title
|
@hanbyul-here i think you've got it all covered! |
|
@hanbyul-here I went through some of the stories and datasets where we have had bugs recently and noticed a few datasets that I couldn't get to load properly. I think these show up in the LA and Lahaina wildfires stories. Otherwise I didn't notice other issues |
|
I confirmed I'm able to see these in production and in the preview for v6.5.0 |
hanbyul-here
force-pushed
the
1545-move-to-raster-paint-layer
branch
from
19783f4 to
71f7827
Compare
|
thank you for throughly testing @aboydnw 🙇 . I handled the case, and also added a test for titiler parameter formatter ( any test case idea is welcome!) |
|
@AliceR 🤔 I do not know why but I think the change here removed the gap between point layer -> raster layer! |
dzole0311
requested changes
Apr 23, 2025
app/scripts/components/common/map/style-generators/raster-paint-layer.tsx
Show resolved
Hide resolved
dzole0311
approved these changes
Apr 29, 2025
aboydnw
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1545
Description of Changes
Validation / Testing
Load all types of datasets (raster, CMR (HLS data - you will need to zoom to minnesota to see the data), WMS (any ESRI data that @Slesa added: https://deploy-preview-1607--veda-ui.netlify.app/exploration?search=arcgis&datasets=%5B%5D&taxonomy=%7B%7D ) - I believe we no longer have a Zarr dataset on production). Ensure they are working as expected. 'Expectation' includes tile loading, zooming to the dataset for raster timeseries data, datetime change, and 'Load into GIS' functionality.
@aboydnw - Can I ask to test if all the layers work as expected? I created a preview on veda config in case this helps: NASA-IMPACT/veda-config#837
@slesaad - Can you check if I am not missing anything from wms layer?