Skip to content

chore: Add publish package step to release #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 17, 2025

Conversation

sandrahoang686
Copy link
Collaborator

@sandrahoang686 sandrahoang686 commented Apr 10, 2025

Related Ticket: #1419

Description of Changes

This only publishes the package to NPM!! To bump up version in NextJs template instance will be a separate PR!! I haven't figured out the 2nd part yet but i didn't want to block this part atleast.

Notes & Questions About Changes

{Add additonal notes and outstanding questions here related to changes in this pull request}

Validation / Testing

{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}

Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 994f0bf
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/68005888c49b6000088b2f4f
😎 Deploy Preview https://deploy-preview-1608--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sandrahoang686 sandrahoang686 changed the title Add publish package step to release chore: Add publish package step to release Apr 10, 2025
@sandrahoang686
Copy link
Collaborator Author

sandrahoang686 commented Apr 10, 2025

Note: test version was published ✅
Screenshot 2025-04-10 at 11 03 40 AM

@sandrahoang686 sandrahoang686 marked this pull request as ready for review April 14, 2025 13:53
@dzole0311
Copy link
Collaborator

@sandrahoang686 Were you able to check whether the release action prevents publishing empty releases?

@sandrahoang686
Copy link
Collaborator Author

sandrahoang686 commented Apr 14, 2025

@dzole0311 doesn't look like it looking at the release file ~

 - name: Release through Git
        id: git-release
        run: yarn release  --ci --verbose
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

and then none of the steps before it looks like its doing any checks, we should probably add that as a part of the ticket though, let me do that. I'll separate from this PR but maybe that should be dependent and we shouldn't release until we have that check? what do you think @dzole0311 @hanbyul-here ?

@hanbyul-here for context, we are bringing up this check because looks like the priorities is around earth.gov instance where much of the teams development time / work will be happening there so we were worried about releasing veda-ui weekly even when not much development will possibily be happening there.

@hanbyul-here
Copy link
Collaborator

This can be a good start to prevent empty commit release: https://github.com/release-it/release-it/blob/main/docs/git.md#no-commits

@dzole0311
Copy link
Collaborator

@sandrahoang686 let's maybe include the git.requireCommits in this PR? Should be a quick addition

@sandrahoang686
Copy link
Collaborator Author

@dzole0311 @hanbyul-here added! can you check if i've added to the correct place?

@dzole0311
Copy link
Collaborator

Seems correct to me 👍

@sandrahoang686 sandrahoang686 merged commit 753fc9b into main Apr 17, 2025
10 checks passed
@sandrahoang686 sandrahoang686 deleted the update/release-for-publish branch April 17, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants