-
Notifications
You must be signed in to change notification settings - Fork 11
chore: Add publish package step to release #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@sandrahoang686 Were you able to check whether the release action prevents publishing empty releases? |
@dzole0311 doesn't look like it looking at the release file ~
and then none of the steps before it looks like its doing any checks, we should probably add that as a part of the ticket though, let me do that. I'll separate from this PR but maybe that should be dependent and we shouldn't release until we have that check? what do you think @dzole0311 @hanbyul-here ? @hanbyul-here for context, we are bringing up this check because looks like the priorities is around earth.gov instance where much of the teams development time / work will be happening there so we were worried about releasing veda-ui weekly even when not much development will possibily be happening there. |
This can be a good start to prevent empty commit release: https://github.com/release-it/release-it/blob/main/docs/git.md#no-commits |
@sandrahoang686 let's maybe include the |
@dzole0311 @hanbyul-here added! can you check if i've added to the correct place? |
Seems correct to me 👍 |
Related Ticket: #1419
Description of Changes
This only publishes the package to NPM!! To bump up version in NextJs template instance will be a separate PR!! I haven't figured out the 2nd part yet but i didn't want to block this part atleast.
Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing
{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}