Skip to content

fix: Do not show configurable colormap for wms, wmts datasets #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2025

Conversation

Copy link

netlify bot commented Jul 16, 2025

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 3857848
🔍 Latest deploy log https://app.netlify.com/projects/veda-ui/deploys/687de64cdfc97a0008e5e42d
😎 Deploy Preview https://deploy-preview-1769--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hanbyul-here hanbyul-here changed the title Do not show configurable colormap when there is no other option for colormap fix: Do not show configurable colormap when there is no other option for colormap Jul 16, 2025
@hanbyul-here hanbyul-here force-pushed the US-GHG-Center/ghgc-architecture#708 branch from a8b3296 to 165c42f Compare July 16, 2025 20:38
@hanbyul-here hanbyul-here force-pushed the US-GHG-Center/ghgc-architecture#708 branch from 165c42f to 66915a3 Compare July 16, 2025 20:49
@hanbyul-here hanbyul-here changed the title fix: Do not show configurable colormap when there is no other option for colormap fix: Do not show configurable colormap for wms, wmts datasets Jul 16, 2025
@hanbyul-here hanbyul-here marked this pull request as ready for review July 16, 2025 20:59
@hanbyul-here hanbyul-here requested a review from dzole0311 July 16, 2025 20:59
…figurableCmap to make sure the loading skeleton and non-configurable colormap don't show up at the same time
Copy link
Collaborator

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the new GEDI L4B Gridded Aboveground Biomass Density dataset, a vector dataset (fire perims) and a raster dataset (Net Ecosystem Exchange) and things are working as expected.

@hanbyul-here hanbyul-here merged commit 46358ee into main Jul 21, 2025
10 checks passed
@hanbyul-here hanbyul-here deleted the US-GHG-Center/ghgc-architecture#708 branch July 21, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants