Skip to content

yaml and python options to define regions #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025
Merged

Conversation

wwieder
Copy link
Collaborator

@wwieder wwieder commented Apr 17, 2025

I pulled the regions and lat-lon boundaries from the .nc file used by the current land diagnostics package to address #376 This was done:

  • manually (maybe introducing errors) and
  • naively (perhaps without the right formatting)

@megandevlan & @samsrabin please see if this yaml file can be read in and used as expected in the regional subsetting you're working on.

Note: there are regions that span 0 longitude. Not sure what the best way to handle this is?
I've also provided lats -180 to 180, as I think this is what uxarray needs, but would have to be modified for xarray datasets that are 0-360.

Finally, I tried using copilot to see if the yaml file was formatted correctly to create a python dictionary and it just created the python dictionary for me! I've included that here too, but both files don't need to be merged. Dealers choice on which you prefer

@wwieder wwieder added the config files Concerns the ADF config (YAML) files label Apr 17, 2025
@wwieder wwieder self-assigned this Apr 17, 2025
@wwieder wwieder changed the title yaml to define regions yaml and python options to define regions Apr 17, 2025
@samsrabin
Copy link
Member

I ended up getting distracted from regions and working on #382 instead, so I'll let @megandevlan handle this. I vote for the actual YAML file though.

@samsrabin samsrabin removed their request for review April 18, 2025 16:03
@megandevlan
Copy link
Collaborator

I vote for the actual yml file as well, though I don't know that I have the bandwidth to test things out today. I can get to this early next week though!

@wwieder
Copy link
Collaborator Author

wwieder commented Apr 18, 2025

OK, I'll merge this in so you have access to the file when you're ready @megandevlan

@wwieder wwieder merged commit f4fa130 into NCAR:clm-diags Apr 18, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config files Concerns the ADF config (YAML) files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants