Skip to content

Conversation

@hkershaw-brown
Copy link
Member

Description:

fix: qty_potential_temperature 3d interpolate in wrf model_mod
k+1 level was using k value for x_iul value

Fixes issue

fixes #1011

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Compared against wrf_unified branch using a function for interpolation for levels k& k+1

function simple_interpolation(ens_size, state_handle, qty, id, ll, ul, lr, ur, k, dxm, dx, dy, dym)

Not tested assimilation, this change will be answer changing.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

k+1 level was using k value for x_iul value

fixes #1011
@hkershaw-brown hkershaw-brown added the wrf Weather Research & Forecasting Model label Dec 8, 2025
Copy link
Contributor

@braczka braczka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait --approved.

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release! bundle with next release wrf Weather Research & Forecasting Model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: wrf Potential Temperature interpolation using incorrect value for one corner

3 participants