Update params #521
Update params #521
Conversation
…ent with the model.
…n the mpas model.
| ! redefined here for consistency with the model (MPAS/src/framework/mpas_constants.F). | ||
| real(r8), parameter :: rgas = 287.0_r8 ! = R_d (Gas constant for dry air [J kg-1 K-1]) | ||
| real(r8), parameter :: rv = 461.6_r8 ! = R_v (Gas constant for water varpor [J kg-1 K-1]) | ||
| real(r8), parameter :: cp = 7.*rgas/2. ! = 1004.5 |
There was a problem hiding this comment.
| real(r8), parameter :: cp = 7.*rgas/2. ! = 1004.5 | |
| real(r8), parameter :: cp = 7.0_r8*rgas/2.0_r8 ! = 1004.5 |
|
MPAS-A model (Version 5+) |
| @@ -7380,7 +7381,7 @@ function theta_to_tk (ens_size, theta, rho, qv, istatus) | |||
|
|
|||
| integer, intent(in) :: ens_size | |||
| real(r8), dimension(ens_size), intent(in) :: theta ! potential temperature [K] | |||
| real(r8), dimension(ens_size), intent(in) :: rho ! dry density | |||
| real(r8), dimension(ens_size), intent(in) :: rho ! dry air density [kg/m3] | |||
There was a problem hiding this comment.
There are a bunch of subroutine arguments labelled as dry density. Should these all be dry air density?
There was a problem hiding this comment.
edit: it is one in compute_full_pressure
There was a problem hiding this comment.
You are right. Here, rho is all 'dry air density'. Nice catch!
|
@soyoung closed #429 because the original pressure calculation appears to be correct, |
| @@ -7457,7 +7458,7 @@ subroutine compute_full_pressure(ens_size, theta, rho, qv, pressure, tk, istatus | |||
| tk = theta_to_tk(ens_size, theta, rho, qv_nonzero, istatus) | |||
|
|
|||
| where (istatus == 0) ! We only take non-missing tk here | |||
| pressure = rho * rgas * tk * (1.0_r8 + 1.61_r8 * qv_nonzero) | |||
| pressure = rho * rgas * tk * (1.0_r8 + rvord * qv_nonzero) | |||
There was a problem hiding this comment.
i wanted to leave a comment on line 7445 - the 'dry density' comment should be 'dry air density' to be consistent. i think that's the last place 'dry density' is in a comment (that i could find) that needs changing. if all these suggested changes are ok, should we go ahead and accept them?
There was a problem hiding this comment.
@nancycollins I'm going to close this pull request and put the constant fix in cleanly.
As Kevin says, it is probably best not to have the Jedi equations in the commits, and we need to add documentation adding about the constant changes.
There was a problem hiding this comment.
@hkershaw-brown, just for clarification, there are no jedi equations or comments here at all. In this PR, I only updated the constants based on the model. I'm curious how you can make the fix cleaner?
There was a problem hiding this comment.
So the Jedi stuff is in the commit history:
There was a problem hiding this comment.
@syha I'm aware you're busy with other things, so I'll put the fix in (I'll add you as a joint commit so you show up in the contributions). Thanks, Helen
There was a problem hiding this comment.
Ah, the commit history, not the code itself. Got it. Thanks!
|
closing - will redo without the Jedi commits. |
Description:
Parameters are updated in model_mod.f90 to be consistent with those in the MPAS-A model (Version 7+).
Fixes issue
fixes #251
theta_m and pressure use rvord (=1.608362) instead of 1.61.
cp is now updated from 1003.0 to 1004.5 and cv is changed from 716.0 to 717.5.
Types of changes
Documentation changes needed?
Tests
In 2-member tests with a single obs for sounding temperature at 700 hPa, new parameters changed all the analysis variables.
Checklist for merging
Checklist for release
Testing Datasets