Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get_channel to obs_def_rttov13_mod.f90 #540

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Added get_channel to obs_def_rttov13_mod.f90 #540

merged 1 commit into from
Sep 14, 2023

Conversation

ann-norcio
Copy link
Contributor

@ann-norcio ann-norcio commented Sep 13, 2023

Description:

radiance_obs_seq_to_netcdf with rttov13 failed to compile with error #6580: Name in only-list does not exist or is not accessible [GET_CHANNEL]. Fix: Added public get_channel to obs_def_rttov13_mod.f90 to compile WRF successfully.

Fixes issue

fixes #532

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Add radiance_obs_seq_to_netcdf to ./quickbuild.sh. Then, run ./quickbuild.sh radiance_obs_seq_to_netcdf on DART/wrf/work.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@mjs2369
Copy link
Contributor

mjs2369 commented Sep 14, 2023

@hkershaw-brown we didn't push Ann's changes to /DART/models/wrf/work/quickbuild.sh

I didn't know whether or not we wanted to build this program every time with WRF, but now I'm thinking that there's probably no reason not to.

Should she commit and push her edit for that?

@hkershaw-brown
Copy link
Member

@hkershaw-brown we didn't push Ann's changes to /DART/models/wrf/work/quickbuild.sh

I didn't know whether or not we wanted to build this program every time with WRF, but now I'm thinking that there's probably no reason not to.

Should she commit and push her edit for that?

So we don't want to have radiance_obs_seq_to_netcdf build by default because it requires the rttov library.

@hkershaw-brown hkershaw-brown changed the base branch from main to fix-int-log-rttov13 September 14, 2023 17:59
Copy link
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix Ann, great work testing the build with rttov.

@hkershaw-brown hkershaw-brown merged commit cd5dc74 into NCAR:fix-int-log-rttov13 Sep 14, 2023
2 checks passed
@hkershaw-brown
Copy link
Member

@ann-norcio
@mjs2369
I merged this pull request into #541 - since we have two single line rttov build fixes to go into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: obs_def_rttov13_mod.f90 does not have public get_channel
3 participants