-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create mkmf.template.nvhpc #557
Create mkmf.template.nvhpc #557
Conversation
Add mkmf.template.nvhpc in build_templates
Nice work testing out all the Derecho compilers and finding this, Ann. There's code in dart that relies on IEEE standard that for a NaN, a /= a is .true. Can you trying building and running the following code on Derecho with nvhpc: code test_nan.f90
You can compile and run it like this:
vs
We want to make sure a /= a gives .true. for a NaN (we may need to add -Kieee to the compile flags in your mkmf.template.) And bonus points, can you add some suggested flags if you want to turn on debugging for nvhpc? |
@hkershaw-brown the nan test should go in a developer test, since we are relying on the IEEE behaviour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Ann, I left a couple of suggestions for ieee and debugging flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the compile with the new debugging flags. Approved
Description:
Created mkmf.template.nvhpc in build_templates to run quickbuild.sh with nvhpc compiler for all models on Derecho. Modified compiler flag
FFLAGS = -O -Mbackslash $(INCS)
to include -Mbackslash, which addresses issue #555Fixes issue
Fixes: #554 #555
Types of changes
Documentation changes needed?
Tests
Copy mkmf.template.nvhpc and set as your mkmf.template. Set compiler to nvhpc
module load nvhpc
. Then, run quickbuild.sh on DART/models/lorenz_63/work.Checklist for merging
Checklist for release
Testing Datasets