Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove loop from Mersenne twister test #561

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

hkershaw-brown
Copy link
Member

Description:

This a couple of commits that were meant to go in pull #549

Fixes issue

See #549
#549 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
Compile and run developer test

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Oct 26, 2023
Copy link
Contributor

@mjs2369 mjs2369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean removal of the ntests loop and the write to an output file. The resulting developer test is simple and effective.

Tested and approved.

@hkershaw-brown hkershaw-brown changed the base branch from main to quickbuild-mpif08 November 7, 2023 19:48
@hkershaw-brown hkershaw-brown merged commit 45013ee into quickbuild-mpif08 Nov 7, 2023
2 checks passed
@hkershaw-brown hkershaw-brown deleted the random-test-no-loop branch November 7, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants