Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for remaining documentation warnings in #546 #573

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

c-merchant
Copy link
Collaborator

@c-merchant c-merchant commented Nov 6, 2023

Description:

This pr fixes the documentation warnings in:
index.rst -> added new_model template and fluxnetfull_to_obs to toctree
models/lorenz_96_tracer_advection/readme.rst -> removed unnecessary indentation in line 66
observations/obs_converters/Ameriflux/level4_to_obs.rst -> uncapitalized "f" for fluxnetfull_to_obs.rst

Fixes issue

This pr resolves the remaining documentation warnings in Issue #546.
fixes #546

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
After these changes, I ran "make clean" then "make html" to verify that no warnings were left.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

Copy link
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Nov 6, 2023
@hkershaw-brown hkershaw-brown changed the base branch from main to quickbuild-mpif08 November 7, 2023 19:46
@hkershaw-brown hkershaw-brown merged commit b324e02 into NCAR:quickbuild-mpif08 Nov 7, 2023
3 checks passed
@c-merchant c-merchant deleted the doc_notes branch July 3, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc notes fluxnetfull, lorenz_96_tracer_advection, clm
2 participants