Conversation
Add module load for all compiler, mpif08 argument for gnu compiler, testing submission script for Derecho
…tter the convert_airs_L2 converter was printing 1 more obs converted than was actually done. also, the settings for the convert_airs_L2 namelist thinned out all the obs. change the defaults to include all possible obs.
nvhpc also needs mpif08
not rm -rf existing runs, instead moving compiled runs to run.$(date)
mjs2369
left a comment
There was a problem hiding this comment.
In order to add ifx to the list of compilers to build with, we need to update fixsystem to include ifx
Co-authored-by: Marlena Smith <44214771+mjs2369@users.noreply.github.com>
|
The builds that use specific libraries such as rttov will be addressed in a future pull request |
will do, thanks Marlee! |
…he files that don't actually call nc_check
ifx mkmf.template
|
I've added ifx. To run, you'll need to run with the quickbuild_tests branch because main does not have the mkmf.template.ifx.linux |
^^^ This should be added to the README And a follow up question @hkershaw-brown - if the submit_jobs.sh script submits a job for each compiler, are we expecting the ifx build to still run and just error out on all branches other than quickbuild_tests? |
mjs2369
left a comment
There was a problem hiding this comment.
Should we add some code for teardown? Currently, consecutive runs will fail with
Directory exists: /glade/derecho/scratch/masmith/build_everything/nvhpc
Nope don't add to the README. When this pull request is merged into main, mkmf.template.ifx.linux will exist on main. This 'To run' note was just for you for this pull request.
Yes because mkmf.template.ifx.linux only exists on the quickbuild_tests branch. |
This is the teardown: If you don't have a compiler.dateTime directory then the job did not finish. |
That makes much more sense and is obvious in hindsight. For some reason, I thought you meant that mkmf.template.ifx.linux was not going to be added to main with this PR. Ignore this. |
|
Sometimes Derecho is unable to make a connection to the DART remote repository, causing some of the jobs to fail with this message: I have submitted a support request with CISL Help to address this issue. |
|
Additional failures with cce: Just making a note of these on this PR, as other failures are noted in the body, but we can create issues for these as well CLM: Line in question - DART/models/clm/dart_to_clm.f90 Line 752 in 74b4221 snlsno(ncolumn), which is the subscript for gain_dzsno, is a real(r8) - changed to integer (line 418) and it compiles DART/models/clm/dart_to_clm.f90 Line 418 in 74b4221 NOAH/WRF_HYDRO: Line in question: DART/models/wrf_hydro/noah_hydro_mod.f90 Line 660 in 74b4221 WRF: Solution is to remove the following line: Compiles after this change |
mjs2369
left a comment
There was a problem hiding this comment.
Ready to merge. The quickbuild failures are being accurately reported
Resolution to Issue #336 - updated nc_check
fix print of number of obs converted, and make input.nml defaults better
mom6 model_mod .eqv. for logicals comparison
Description:
building on Ann's previous pull request #575
improved build_everything, submits a job on Derecho for each compiler, each job runs every quickbuild.sh
time:
ccc ~12minutes
gfortran ~2:30 minutes
nvhpc ~4:40 minutes
ifort ~4:40 minutes
Note several of the converters require external libraries or code to be added before compiling, ignoring these for this pull request (rttov, hdfeos, wrf code, ncep prepbuf code):
Other failures: #592 #352, #594
Types of changes
Documentation changes needed?
Tests
Derecho: build everything (that has a quickbuild.sh) in DART for cce, intel, gcc, nvhpc
Checklist for merging
Checklist for release
Testing Datasets