Remove loops over calendar types where not needed #767
+32
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The subroutines set_calendar_type_string and get_calendar_string in the time_manager_mod have unnecessary loops over the number of max_types (calendar types). This PR removes these loops for improved code efficiency and readability
Fixes issue
fixes #653
Types of changes
Documentation changes needed?
Tests
Ran model_mod_check and filter with print statements to ensure the correct calendar_type was being set/used
Checklist for merging
Checklist for release
Testing Datasets