Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified oned/obs_diag.f90 to add an unused singleton level #791

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

jlaucar
Copy link
Contributor

@jlaucar jlaucar commented Jan 8, 2025

Modified oned/obs_diag.f90 to add an unused singleton level
dimension to the output netcdf fields. These files now work with all of the relevant observation space diagnostic matlab programs. This was tested for plot_rank_histogram.m, plot_evolution.m, and plot_rmse_xxx_evolution.m for lorenz_96, lorenz_63, lorenz_84, and lorenz_96_tracer_advection, the latter with multiple observation types.

Description:

Added a new level dimension, added extra dimensions to array that processes the input from the obs_seq file.

Fixes issue 230

fixes #230

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

See summary.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

dimension to the output netcdf fields. These files now work with
all of the relevant observation space diagnostic matlab programs.
This was tested for plot_rank_histogram.m, plot_evolution.m, and
plot_rmse_xxx_evolution.m for lorenz_96, lorenz_63, lorenz_84,
and lorenz_96_tracer_advection, the latter with multiple observation
types.
@hkershaw-brown
Copy link
Member

Code changes look good. What do you need from this review, do you want someone to run the plots for a quick sanity check, or good to go?

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jan 8, 2025
@jlaucar
Copy link
Contributor Author

jlaucar commented Jan 8, 2025 via email

@hkershaw-brown hkershaw-brown merged commit f2deaa2 into main Jan 9, 2025
4 checks passed
@hkershaw-brown hkershaw-brown deleted the oned_obs_diag_fix branch January 9, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: plot_rmse_xxx_evolution.m and plot_evolution not working with 1D location
2 participants