Interface to a New Hydrologic Model "pywatershed" #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new model and added necessary testing files including network parameters and sample restarts
Added model namelist parameters in the input.nml and modified the model_mod.f90 accordingly. Also, did some clean-up of the model_mod
Added geometry files and started populating static_init_model
Added logic to manage active domains
Added channel and hru domains. Also, defined and coded all connectivity information including the relationship between streamflow and HRUs model_mod is almost complete!
Added: - GSMD - GC - PMC - RMT Also, read lon of segments from shapefile and added them to geometry file to be used for constructing connectivity structure.
The function can be run in Matlab only once for any DA experiment. It will create an appended geometry file with teh necessary Routelike-style variables. I've also done some cleaning of the model-mod.
Tested filter with two sets of obs_seq files, assimilating 1 and 2 obs. Both serial and parallel runs of filter gave the same exact results. Also, cleaned up the directories and screated a scripts dir.
Fixed typo and reset the debug flag
Started documentation by adding readme.rst file
Added pywatershed to the list of supported models
Added rotuines for converting USGS streamflow observations. The program 'create_identity_streamflow_obs' is heavily based on the already available USGS converter. It adds new capabilities such as: identity obs evaluation and unit conversion. Note that the new program is needed because the filing structure and network in pywatershed in different than wrf_hydro
On top of append_seg_data.m, I now added a python function with the same functionality .. better fitting with the HydroDART workflow.
Going from reading integer gauge IDs into characters. This would remove the need to pad the strings with '0'
Used the mask array to simplify get_close when adding the contributing groundwater basins
Included another check on the HRUs while executing ATS localization. This now makes sure the individual close HRUs are active.
Indexing into the type of HRUs was incorrectly specified. It was using the full state index to access arrays within the HRU domain only.
After reading model time, the file was not being closed. This caused an error when overwriting the update on the same input ensemble files.
Matlab-based diagnostic scripts for pws-dart experiments. - pwsDARTdiags.m assembles the data from obs_diag_output and obs_epoch netCDF files and creates ensemble time-series plots - summary_diags_pws.m summarizes all results into boxplots and saves the prior and posterior statistics into text files - run_pwsDARTdiags.m calls pwsDARTdiags.m with a specified configuration
- Updated the streamflow file with the instantaneous streamflow. The previous file used the daily averaged streamflow - Modified the input.nml to reflect the usage of the new streamflow - Fixed a bug in the diag scripts that prevented the analysis on certain gauges. These come in after fully testing the system and completing 6-months worth of assimilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces an interface to USGS's new hydrologic model "pywatershed". The PR also includes an observation converter that supports assimilating streamflow gauges, including USGS's recent next-generation water observing system (NGWOS) sensors.
Types of changes
Documentation changes needed?
Tests
I've run all
model_mod_checktests. I've also run severalfilterexperimentsChecklist for merging
Checklist for release
Testing Datasets
Testing dataset can be found here:
/glade/work/gharamti/DART/usgs_hydro/models/pywatershed/work