Print version of DART when running 'filter'

[tyiop794]

Description:

DART prints the version (retrieved using 'git describe --dirty --tags') when it is run.

Fixes issue

fixes #747

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Documentation changes needed?

• My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

I have run the filter program multiple times. However, the tags do not seem to have transferred over to my fork, so in my case DART only prints 'unknown'. I'm still not sure how I would transfer those tags over.

Checklist for merging

• Updated changelog entry
• Documentation updated
• Update conf.py

Checklist for release

• Merge into main
• Create release from the main branch with appropriate tag
• Delete feature-branch

Testing Datasets

• Dataset needed for testing available upon request
• Dataset download instructions included
• No dataset needed

[tyiop794]

I'm struggling to get the CI build checks to pass, which is strange because it builds on my machine fine. It looks like it's unable to find the file containing the function that prints the version?

[hkershaw-brown]

Thanks @tyiop794! It might be a week or two before we look at this because there are several pull requests in the queue.

[hkershaw-brown]

Backed up this branch here: https://github.com/hkershaw-brown/DART/tree/747-dart-version
About to squash the history in this pull request.

[hkershaw-brown]

Hi Kamil, this is nice.

There are a couple of things:
The bash version function dartversion() is duplicated, and would also need to be duplicated in buildconvfunctions.sh (functions to build observation converters). The buildconv and buildfunctions source buildpreprocess.sh so I believe the dartversion only needs to be defined in buildpreprocess.sh - I will go ahead and do this to convince myself that this is correct.

Currently this is collecting all .F90 files in the repo. There is a single .F90 in the GSI converter that gets preprocessed with its own cpp flags.

DART/observations/obs_converters/GSI2DART/work/quickbuild.sh

Lines 30 to 32 in e08756e

	# run the c preprocessor on enkf/kinds.F90
	\rm -f ../enkf/mykinds.f90
	cpp -P -D_REAL8_ -traditional-cpp ../enkf/kinds.F90 > ../enkf/mykinds.f90

I actually think we should collect all .F90 files (see #696) but I am thinking for this pull request, we should be conservative add the single file version_mod.F90 to the list of source files. That way if people are making use of there own .F90 to .f90 we do not break their builds.

Cheers,
Helen

[hkershaw-brown]

Also mkmf has the svn $Id$ which is from when DART was using svn for version control not git.

DART/build_templates/mkmf

Line 46 in e08756e

my $version = '$Id$ ';

so the Makefile created has this on the first line;

  1 # Makefile created by mkmf $Id$ 
  2 
  3 include /Users/hkershaw/DART/pull_requests/pull_983/build_templates/mkmf.template
  4 CPPDEFS = -DDART_VERSION="'v11.19.1-1-ga74da6ec0-dirty'"
  5 
  6 .DEFAULT:

I wonder if we can use opt_c to set the version in the Makefile.

[hkershaw-brown]

@hkershaw-brown todo run build everything on this pull request.

[hkershaw-brown]

Super helpful Kamil, thanks for working on this!
Finally got to reviewing it, Approved!