-
Notifications
You must be signed in to change notification settings - Fork 166
doc: Relocate pdfs for DART_LAB and DART tutorial. #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pdfs hosted on external ncar GitHub pages site, https://ncar.github.io/dart-tutorial/ DART tutorial is now one slide, DART_LAB part 6. Embedded this in the DART tutorial rst page. Deleted old DART tutorial (slides section 1-25) Rewrote DART_LAB intro to say it is a Matlab based tutorial Reorded the tutorial in the table of contents to have DART_LAB before the DART tutorial
Orignally part of pull #810 Note if you are running 'out-of-the-box' bitwise tests with lorenz_96 this will break them as the default input.nml settings. jla commit messages from #810: Removing deprecated files that were used for the old workshop tutorial. Modified input.nml so that the default run gives reasonably good results. Explicitly use a qceff_table file in the input.nml to facilitate exploration. Added qceff_tables for eakf, bnrhf, and enkf. Added obs_seq files for the identity observation experiments in L96 and the input files used to create those obs_seq files. This allows reproducing the different obs networks from run_lorenz_96.m
mjs2369
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the slides themselves (which I didn't review), this is looking good.
I'm a little unsure about the DART Tutorial now being section 6 of the DART_LAB. I get that it builds on the information from sections 1-5, but it is distinct in that the DART_LAB teaches the fundamentals of DA while the DART Tutorial teaches you to actually use DART. It definitely makes it feel like you would need to go through sections 1-5 first as a new user, even if you are already knowledgeable about the concepts of ensemble DA. Maybe just adding a note to the documentation about how if you do already have this knowledge, you can go ahead and start with section 6?
Finally, do we need the 3 identity_obs_XX.input files in both models/lorenz_96/ and models/lorenz_96/work ?
Kevin reviewed the slides a while ago in pull #810
I share this concern, however this is how Jeff wants the tutorial to be. Do you mean add a note in the DART_LAB section https://dart-documentation--985.org.readthedocs.build/en/985/guide/DART_LAB/DART_LAB.html, something like "If you are already familiar with ensemble DA, you can skip straight to using [DART](link to DART_LAB_section6)". Is that enough to direct people to DART who want to skip the Matlab?
|
Yeah I think that will be good |
|
Making clear the relation between section 6 and the 5 original sections is a key point. I think Marlee's suggestion makes it work. I think a user that does the first 5 sections themselves will have no confusion about what is going on. The real issue is folks who just want to do the DART part and how they would find this section from the higher level documentation. I don't think we know how many users use DART_LAB without being sent there by a DAReS person or being a participant in a formal tutorial. The identity_obs... files in both the Lorenz_96 model directory and work directory are required parts of the section 6 tutorial and should be in the repo. As Helen notes, the slides have been vetted by Kevin and have been used in three live tutorials I've given with nearly 250 total participants including many DA experts. No doubt there are still errors, but I think they do not need any additional review at this time. The one thing that might be needed is for someone other than me to actually go through section 6 and try to do the suggested exercises. That should take less than an hour for a DAReS team member. |
|
@jlaucar, I can volunteer to do that unless you think someone other than me should do it (given my DA background). |
|
Moha, please go ahead and run through section 6, thanks. |
Note the pdfs are not in the DART repo, they are here: https://github.com/NCAR/dart-tutorial. |
|
@todo add "this breaks bitwise" to release notes for out-of-the-box input.nml lorenz |
|
Is the aether_michigan branch where Moha would find the additional low-order model files that are needed to run section6? |
Nope. This branch dartlab-part6 https://github.com/NCAR/DART/pull/985/files |
add anchor to DART tutorial readme.rst
When GitHub insights is not down, we do get some info about this in the referring sites and popular content sections. |
The ones in lorenz_96 are input for create_obs_sequence does not seem to be covered in the dart_lab slides part6, maybe covered live. |
|
I've gone through section 6 and did all exercises. I found no issues. |
Note the identity_obs*.input files in the models/lorenz_96 directory are input for create_obs_sequence. These are not used in the tutorial.
7a97764 to
366f2ba
Compare
@mjs2369 I put a note in commit 366f2ba about what the models/lorenz_96 files are + there are the notes in this pull request, so whoever works with this in the future has some record of what the files are. |
Description:
This pull request relocates pdfs for DART_LAB and the DART tutorial to outside the NCAR/DART repo.
Note the website has an old-old version of the DART Tutorial. That will be switched out once this pull request is okayed (or not).
Fixes issue
Fixes #725
See #810 for conversation on removing old dart tutorial.
⚠️ Todo add lorenz_96 input files from https://github.com/NCAR/DART/pull/810/filesdoneTypes of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Built documentation locally, clicky-click links. Tested pdf embedding: chrome, firefox, safari.
Checklist for merging
Checklist for release
Testing Datasets