GSI2DART: replaced certain mpi functions with DART abstracted versions#987
Closed
GSI2DART: replaced certain mpi functions with DART abstracted versions#987
Conversation
Member
|
@tyiop794 thanks for taking a look at this. Currently we do not have GSI input to test this, so I'm closing this pull request for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I replaced the MPI functions used in GSI2DART with the variants found in mpi_utilities_mod.f90. While this version does compile, I still am not sure whether it works as intended, and I'm not sure how to test.
Fixes issue
fixes #633
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
This version actually compiles with GNU Fortran versions above 11.2.0 (tested with version 15.2.1). However, I'm not sure how to test whether the compiled binary produces the correct output.
Checklist for merging
Checklist for release
Testing Datasets