HF (High Frequency) Radar Ocean Obs Converter #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added and tested functionality of the HF radar converter - It allows the assimilation of U, V, and radial components - Radial components make use of the radial FO in obs_def_ocean - The radial velocities add instrument ID and angle in the obs_seq file - The FO operator is updated to allow for zero bearing angle from the instrument
Also added links in the toctree
Allows observations to be added in different time order.
Comment on lines
354
to
356
| .. tip:: | ||
| * When converting many files, prefer ``file_list`` for clearer logging and | ||
| correct pre-allocation. |
Member
There was a problem hiding this comment.
This is mentioned in #991 also and I am a little confused about the intent. A couple of questions come up: Why give people the option of a single file vs. a list? Is the pre-allocation incorrect with a single file?
Contributor
Author
There was a problem hiding this comment.
Good question. I also debated that. I ended up giving both single and list options mainly for 2 reasons:
- to be consistent with other obs_converters and the obs programs in DART
- for training/testing purposes (upcoming in April next year), people would be interested in looking at the functionality using a single obs file that perhaps has 1 timestamp in it.
Perhaps, I can update that tip for clarity.
Contributor
Author
There was a problem hiding this comment.
Cleaned some of the docs and removed unnecessary statements
mjs2369
reviewed
Nov 6, 2025
mjs2369
approved these changes
Nov 11, 2025
Contributor
mjs2369
left a comment
mjs2369
left a comment
There was a problem hiding this comment.
Ready to merge, nice work Moha!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added a new observation converter that allows for assimilation of ocean currents. It supports total U and V vector components in addition to radial ones. The radial ones make use of a slightly modified radial FO operator. The PR also includes a detailed documentation of the converter.
This effort is part of the Baron collaboration on the InaCAWO project.
Types of changes
Documentation changes needed?
Tests
I have run the converter extensively using single and multi raw obs files. I also used different observation types (radials vs totals) to validate the functionality. I also ran filter using the resulting obs_seq file (~7000 obs) and assessed teh results. I included a figure from a filter run in the documentation of the converter.
Checklist for merging
Checklist for release
Testing Datasets
Dataset can be accessed here:
/glade/derecho/scratch/gharamti/inacawo/DART/observations/obs_converters/HFradar/data