Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mct cap #257

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Deprecate mct cap #257

merged 3 commits into from
Sep 12, 2023

Conversation

alperaltuntas
Copy link
Member

The mct cap is no longer supported or tested. This PR moves mct_cap directory to STALE_mct cap as a first step to remove it for good.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5bc0c5e) 37.90% compared to head (fab929b) 37.90%.

❗ Current head fab929b differs from pull request most recent head 8397546. Consider uploading reports for the commit 8397546 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           dev/ncar     #257   +/-   ##
=========================================
  Coverage     37.90%   37.90%           
=========================================
  Files           269      269           
  Lines         77176    77176           
  Branches      14170    14170           
=========================================
+ Hits          29253    29256    +3     
+ Misses        42643    42640    -3     
  Partials       5280     5280           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gustavo-marques
Copy link
Collaborator

@alperaltuntas , should these lines also be removed?

@alperaltuntas
Copy link
Member Author

@alperaltuntas , should these lines also be removed?

done. please squash and merge if/when ready.

@gustavo-marques gustavo-marques merged commit d363034 into dev/ncar Sep 12, 2023
17 checks passed
@alperaltuntas alperaltuntas deleted the discontinue_mct_cap branch October 22, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants