Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KE-conserving correction to velocity remap #277

Merged
merged 4 commits into from
May 24, 2024

Commits on Apr 24, 2024

  1. KE-conserving Remap Correction

    This commit introduces a method that corrects the remapped velocity so
    that it conserves KE. The correction is activated by setting
    `REMAP_VEL_CONSERVE_KE = True`
    The commit also introduces two new diagnostics:
    `ale_u2` and `ale_v2`
    These track the change in depth-integrated KE of the u and v components
    of velocity before the correction is applied. They can be used even
    if the remapping correction is not turned on.
    iangrooms committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d7b110f View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Limit KE-conserving correction

    This commit does two main things.
    - Limit the magnitude of the multiplicative correction applied to
    the baroclinic velocity to +25%. This prevents rare occasions where
    the correction creates very large baroclinic velocities.
    - Move the diagnostic of KE loss/gain from before the correction
    to after the correction. Without the limit (above) the correction
    is exact to machine precision, so there was no point in computing
    it after the correction. With the new limit it makes sense to
    compute the diagnostic after the correction.
    iangrooms committed May 1, 2024
    Configuration menu
    Copy the full SHA
    bee7499 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    fb2b433 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Correct Units

    This commit addresses @Hallberg-NOAA's comments on
    [the PR](NCAR#277). Computations of
    `ale_u2` and `ale_v2` are updated to work correctly in both
    Boussinesq and non-Boussinesq modes.
    iangrooms committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b182900 View commit details
    Browse the repository at this point in the history