-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify NUOPC cap to accept separate glc runoff fluxes #288
Conversation
@@ -472,6 +474,16 @@ subroutine convert_IOB_to_fluxes(IOB, fluxes, index_bounds, Time, valid_time, G, | |||
fluxes%frunoff(i,j) = kg_m2_s_conversion * IOB%frunoff(i-i0,j-j0) * G%mask2dT(i,j) | |||
endif | |||
|
|||
! add liquid glc runoff flux via rof | |||
if (associated(IOB%lrunoff_glc)) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep these new fields separate in fluxes and not under fluxes%lrunoff
and fluxes%frunoff
.
Suggestion:
fluxes%lrunoff_glc(i,j) = fluxes%lrunoff_glc(i,j) + kg_m2_s_conversion * IOB%lrunoff_glc(i-i0,j-j0) * G%mask2dT(i,j)
fluxes%frunoff_glc(i,j) = fluxes%frunoff_glc(i,j) + kg_m2_s_conversion * IOB%frunoff_glc(i-i0,j-j0) * G%mask2dT(i,j)
Thanks for this PR, @alperaltuntas! Are the changes in src/initialization/MOM_shared_initialization.F90 intended? In addition to what I mentioned above, we also need to:
We should only account for
|
…ds for lrunoff_glc and frunoff_glc.
6b3720c
to
32f7d24
Compare
@gustavo-marques I just pushed a commit here and a PR to CMEPS (ESCOMP/CMEPS#489) to address your comments. One outstanding task is to determine what to do with the diagnostics associated with |
These are the new available diagnostics:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion: only make the new diagnostics available if GLC is active.
This PR addresses issue #281
Changes made:
.true.
. If EMC folks decide the import these fluxes in the same way in the future, the import statements can be taken out of the if-blocks.