Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vel remap dim cons fix #310

Closed

Conversation

alperaltuntas
Copy link
Member

No description provided.

@alperaltuntas
Copy link
Member Author

@mnlevy1981, unless I did something wrong, those two changes don't seem to fix the issue.

@mnlevy1981
Copy link
Collaborator

It's good that these are round-off level differences, right? And only two tests fail instead of three?

< u-point: mean=  -9.3226016410733365E-11 min=  -9.5585579198023948E-10 max=  -2.4508340098930808E-12 ocean_model-ale_u2
< u-point: c=      2628 ocean_model-ale_u2
< v-point: mean=  -3.1669941305055526E-13 min=  -2.3476488491436679E-12 max=   6.6033457594293197E-14 ocean_model-ale_v2
< v-point: c=      2168 ocean_model-ale_v2
---
> u-point: mean=  -9.3226016410733365E-11 min=  -9.5585579198023969E-10 max=  -2.4508340098930808E-12 ocean_model-ale_u2
> u-point: c=      2624 ocean_model-ale_u2
> v-point: mean=  -3.1669941305055526E-13 min=  -2.3476488491436683E-12 max=   6.6033457594293184E-14 ocean_model-ale_v2
> v-point: c=      2172 ocean_model-ale_v2

instead of

 < u-point: mean=  -9.6488926985109026E-08 min=  -9.8931074469954800E-07 max=  -2.5366132002393387E-09 ocean_model-ale_u2
< u-point: c=      2658 ocean_model-ale_u2
< v-point: mean=  -3.2778389250732474E-10 min=  -2.4298165588636968E-09 max=   6.8344628610093448E-11 ocean_model-ale_v2
< v-point: c=      2254 ocean_model-ale_v2
---
> u-point: mean=  -9.3226016410733365E-11 min=  -9.5585579198023969E-10 max=  -2.4508340098930808E-12 ocean_model-ale_u2
> u-point: c=      2624 ocean_model-ale_u2
> v-point: mean=  -3.1669941305055526E-13 min=  -2.3476488491436683E-12 max=   6.6033457594293184E-14 ocean_model-ale_v2
> v-point: c=      2172 ocean_model-ale_v2

(I guess < is current PR, and > is baseline?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants