Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KPP OBLdepth to restart file #319

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

mnlevy1981
Copy link
Collaborator

Created a register_KPP_restarts() subroutine that allocates KPP_CS and also memory for KPP's boundary layer depth, and then adds the BLD to restarts if FPMix is turned on. We really only need BLD in the restart if FPMIX=True and DIABATIC_FIRST=False, but I think basing whether or not to write to the restart file solely on FPMIX is okay

Created a register_KPP_restarts() subroutine that allocates KPP_CS and also
memory for KPP's boundary layer depth, and then adds the BLD to restarts if
FPMix is turned on. We really only need BLD in the restart if FPMIX=True and
DIABATIC_FIRST=False, but I think basing whether or not to write to the restart
file solely on FPMIX is okay
@mnlevy1981
Copy link
Collaborator Author

I want to test these changes with updates that let FPMIX=True runs pass CESM's debug tests, because right now this code still fails ERS.TL319_t232_wg37.GW_JRA.derecho_intel tests and I think hope the memory issues caught by debug tests is to blame

@mnlevy1981 mnlevy1981 marked this pull request as ready for review October 30, 2024 02:56
@mnlevy1981
Copy link
Collaborator Author

This is ready for review, or I can add it to #320. With the source mods in #320 it passes ERS.TL319_t232_wg37.GW_JRA.derecho_gnu and ERS.TL319_t232_wg37.GW_JRA.derecho_intel tests, and in lieu of a baseline comparison I verified that solutions are bit-for-bit with an ERS test off dev/ncar prior to the restart (and the restart files are identical except for the new variable introduced in this branch)

@mnlevy1981 mnlevy1981 merged commit 2cf0fac into NCAR:dev/ncar Oct 30, 2024
10 checks passed
@mnlevy1981 mnlevy1981 deleted the fpmix_restart branch October 30, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants