Skip to content

Diffusion WXFormer model and training code #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 30, 2025
Merged

Diffusion WXFormer model and training code #193

merged 24 commits into from
Jul 30, 2025

Conversation

jsschreck
Copy link
Collaborator

No description provided.

@jsschreck jsschreck requested review from djgagne and WillyChap May 9, 2025 20:48
Copy link
Collaborator

@djgagne djgagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of small changes requested.

last_channel.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this from the repo?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should go in config.

Copy link
Collaborator

@djgagne djgagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to fix conflict text not removed.

@djgagne
Copy link
Collaborator

djgagne commented Jul 30, 2025

I commented out the SKEBS random test that was loading a quarter degree model and data cube in, which had the side effect of breaking the Github Actions runner. We will need to replace the quarter degree model with a much smaller one in the future. Tests pass now, so merging.

@djgagne djgagne self-requested a review July 30, 2025 19:45
Copy link
Collaborator

@djgagne djgagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@djgagne djgagne merged commit 963edb3 into main Jul 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants